Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table:fix desc table not compatibile with MySQL #10022

Merged
merged 5 commits into from
Apr 4, 2019

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Apr 3, 2019

What problem does this PR solve?

Fix desc table not compatible with MySQL. #9983

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #10022 into master will increase coverage by 0.0048%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10022        +/-   ##
================================================
+ Coverage   77.5135%   77.5183%   +0.0048%     
================================================
  Files           403        403                
  Lines         81916      81898        -18     
================================================
- Hits          63496      63486        -10     
+ Misses        13708      13707         -1     
+ Partials       4712       4705         -7

@ngaut
Copy link
Member

ngaut commented Apr 3, 2019

/run-all-tests

@xiekeyi98
Copy link
Contributor

I will help you to fix the test.

@b41sh
Copy link
Member Author

b41sh commented Apr 3, 2019

thank you @xiekeyi98

@xiekeyi98 xiekeyi98 changed the title fix desc table not compatibile with MySQL table:fix desc table not compatibile with MySQL Apr 3, 2019
@xiekeyi98 xiekeyi98 added contribution This PR is from a community contributor. type/compatibility labels Apr 3, 2019
@xiekeyi98
Copy link
Contributor

/run-all-tests tidb-test=pr/774

@xiekeyi98
Copy link
Contributor

/run-all-tests tidb-test=pr/774

@qw4990 qw4990 requested review from erjiaqing, qw4990 and xiekeyi98 April 3, 2019 12:33
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erjiaqing
Copy link
Contributor

LGTM

@qw4990
Copy link
Contributor

qw4990 commented Apr 4, 2019

/run-all-tests

@xiekeyi98
Copy link
Contributor

/run-all-tests tidb-test=pr/774

Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
DO NOT REMEBER to review this PR: https://github.com/pingcap/tidb-test/pull/774

@zhouqiang-cl
Copy link
Contributor

/run-all-tests tidb-test=pr/774

@xiekeyi98 xiekeyi98 added the status/LGT3 The PR has already had 3 LGTM. label Apr 4, 2019
@ngaut ngaut merged commit 62b209c into pingcap:master Apr 4, 2019
@b41sh b41sh deleted the fix-desc-table-compatibility branch July 5, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT3 The PR has already had 3 LGTM. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants