Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: push down constant filters over join properly (#9848) #10049

Merged
merged 5 commits into from
Apr 8, 2019
Merged

plan: push down constant filters over join properly (#9848) #10049

merged 5 commits into from
Apr 8, 2019

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Apr 4, 2019

cherry-pick #9848

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Apr 4, 2019
@eurekaka
Copy link
Contributor Author

eurekaka commented Apr 4, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@eurekaka eurekaka requested review from zz-jason, alivxxx and winoros April 4, 2019 10:20
zz-jason
zz-jason reviewed Apr 5, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 5, 2019
alivxxx
alivxxx approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2019
@zz-jason zz-jason merged commit 0f97e0b into pingcap:release-2.1 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@alivxxx alivxxx alivxxx approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eurekaka @zz-jason @alivxxx