Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle maketime unsigned hour overflow(#10074) #10089

Merged
merged 3 commits into from
Apr 11, 2019
Merged

expression: handle maketime unsigned hour overflow(#10074) #10089

merged 3 commits into from
Apr 11, 2019

Conversation

AndrewDi
Copy link
Contributor

@AndrewDi AndrewDi commented Apr 9, 2019

cherry-pick #10074

@AndrewDi
Copy link
Contributor Author

AndrewDi commented Apr 9, 2019

/run-all-tests

@AndrewDi
Copy link
Contributor Author

AndrewDi commented Apr 9, 2019

@qw4990 PTAL

@qw4990
Copy link
Contributor

qw4990 commented Apr 10, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990 qw4990 self-requested a review April 10, 2019 03:25
@qw4990 qw4990 added component/expression contribution This PR is from a community contributor. labels Apr 10, 2019
@qw4990
Copy link
Contributor

qw4990 commented Apr 10, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Apr 10, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

crazycs520
crazycs520 reviewed Apr 10, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qw4990
qw4990 approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Apr 10, 2019
@zz-jason
Copy link
Member

/run-check_dev

@zz-jason zz-jason merged commit 998cbf6 into pingcap:release-2.1 Apr 11, 2019
@AndrewDi AndrewDi deleted the release-2.1 branch February 1, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewDi @qw4990 @zz-jason @crazycs520