Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table, infoschema, executor: fix Charset/Collation shown in column(#10007) #10114

Merged
merged 2 commits into from
Apr 10, 2019

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Apr 10, 2019

What problem does this PR solve?

Cherry-pick #10007

@bb7133 bb7133 force-pushed the bb7133/fix_show_column-cherry branch from 45c9cb7 to 08ca1a5 Compare April 10, 2019 14:36
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member Author

bb7133 commented Apr 10, 2019

/run-all-tests tidb-test=pr/785 tikv=release-2.1 pd=release-2.1

@winkyao winkyao added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Apr 10, 2019
@bb7133 bb7133 added type/2.1 cherry-pick and removed priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Apr 10, 2019
@winkyao winkyao added component/charset priority/release-blocker This issue blocks a release. Please solve it ASAP. type/2.1 cherry-pick and removed type/2.1 cherry-pick labels Apr 10, 2019
@bb7133
Copy link
Member Author

bb7133 commented Apr 10, 2019

/run-all-tests tidb-test=pr/785 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli
Copy link
Member

shenli commented Apr 10, 2019

LGTM

@shenli shenli merged commit 9a2d2da into pingcap:release-2.1 Apr 10, 2019
@bb7133 bb7133 deleted the bb7133/fix_show_column-cherry branch December 29, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/charset priority/release-blocker This issue blocks a release. Please solve it ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants