Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: show memory consumption in slow query log #10162

Merged
merged 8 commits into from
Apr 18, 2019
Merged

executor: show memory consumption in slow query log #10162

merged 8 commits into from
Apr 18, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 16, 2019

What problem does this PR solve?

Add memory consumption in slow query log.

What is changed and how it works?

  1. Add maxBytes into mem.Tracker to trace max number of bytes memory consumed during execution.
  2. Update SlowLogFormat to add memory consumption in slow log.

Check List

Tests

  • Unit test

@qw4990 qw4990 added the sig/execution SIG execution label Apr 16, 2019
@codecov
Copy link

codecov bot commented Apr 16, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e13181f). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #10162   +/-   ##
===========================================
  Coverage          ?   77.9414%           
===========================================
  Files             ?        405           
  Lines             ?      82331           
  Branches          ?          0           
===========================================
  Hits              ?      64170           
  Misses            ?      13420           
  Partials          ?       4741

@qw4990 qw4990 requested a review from alivxxx April 16, 2019 06:16
alivxxx
alivxxx reviewed Apr 16, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 17, 2019

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2019

All conflicts have been resolved, PTAL.

zz-jason
zz-jason reviewed Apr 18, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2019

/run-all-tests

@qw4990 qw4990 merged commit f834e5d into pingcap:master Apr 18, 2019
qw4990 added a commit to qw4990/tidb that referenced this pull request Apr 24, 2019
@qw4990
executor: show memory consumption in slow query log (pingcap#10162)
9a28918
@qw4990 qw4990 mentioned this pull request Apr 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@zz-jason zz-jason zz-jason approved these changes

@winkyao winkyao Awaiting requested review from winkyao

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qw4990 @zz-jason @alivxxx