executor: fix IsPointGet judgment condition #10278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index lookup should not the max ts optimization
shenli
added
priority/release-blocker
|
@tiancaiamao Please fix CI. |
jackysp
reviewed
Apr 28, 2019
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10278 +/- ##
===============================================
+ Coverage 77.8185% 77.8256% +0.007%
===============================================
Files 410 410
Lines 84724 84733 +9
===============================================
+ Hits 65931 65944 +13
+ Misses 13863 13861 -2
+ Partials 4930 4928 -2 |
winoros
reviewed
Apr 28, 2019
go.mod
Outdated
| @@ -55,6 +55,7 @@ require ( | |||
| github.com/spaolacci/murmur3 v0.0.0-20180118202830-f09979ecbc72 | |||
| github.com/struCoder/pidusage v0.1.2 | |||
| github.com/tiancaiamao/appdash v0.0.0-20181126055449-889f96f722a2 | |||
| github.com/tiancaiamao/debugger v0.0.0-20190426085344-91156e93f38e | |||
There was a problem hiding this comment.
Can we put this package into failpoint?
There was a problem hiding this comment.
winkyao
reviewed
Apr 28, 2019
winkyao
reviewed
Apr 28, 2019
winkyao
reviewed
Apr 28, 2019
winkyao
reviewed
Apr 28, 2019
| debugger.Continue("point-get-g1") | ||
| debugger.Break(label) | ||
| tk2.MustExec("update point_get set b = 2, c = 2 where a = 1") | ||
| debugger.Continue("point-get-g1") |
There was a problem hiding this comment.
continue "point-get-g1" is right here... it means notify the other goroutine to continiue, not this one...
Notify the "select c from point_get where b = 1" transaction, to continue the second get(key)
winkyao
reviewed
Apr 28, 2019
|
Please fix ci |
|
I tried |
|
@tiancaiamao well, let's focus on the bug fixing. |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Apr 29, 2019
index lookup should not use the max ts optimization
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Apr 29, 2019
fix IsPointGet judgment condition
jackysp
pushed a commit
that referenced
this pull request
Apr 30, 2019
jackysp
added a commit
that referenced
this pull request
Apr 30, 2019
jackysp
pushed a commit
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
index lookup should not use the max ts optimization
What is changed and how it works?
fix IsPointGet judgment condition
Check List
Tests
Related changes