Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod, ddl: update go.mod and fix related tests #10283

Merged
merged 4 commits into from
Apr 28, 2019
Merged

Conversation

spongedu
Copy link
Contributor

What problem does this PR solve?

Fix related tests for pingcap/parser#201, and update parser version in go.mod.

What is changed and how it works?

Fix related tests for pingcap/parser#201, and update parser version in go.mod.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

@spongedu
Copy link
Contributor Author

@kennytm @winkyao PTAL

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #10283 into master will decrease coverage by 0.0642%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #10283        +/-   ##
================================================
- Coverage   77.8169%   77.7526%   -0.0643%     
================================================
  Files           410        410                
  Lines         84578      84536        -42     
================================================
- Hits          65816      65729        -87     
- Misses        13846      13899        +53     
+ Partials       4916       4908         -8

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented Apr 28, 2019

Please fix ci

@tiancaiamao
Copy link
Contributor

/run-all-tests

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit 82782a1 into pingcap:master Apr 28, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants