-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikvclient: fix a bug that recreate connection forever #10301
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10301 +/- ##
================================================
- Coverage 77.8087% 77.7852% -0.0236%
================================================
Files 410 410
Lines 84966 84930 -36
================================================
- Hits 66111 66063 -48
- Misses 13909 13917 +8
- Partials 4946 4950 +4 |
Codecov Report
@@ Coverage Diff @@
## master #10301 +/- ##
================================================
- Coverage 77.6681% 77.6575% -0.0107%
================================================
Files 411 411
Lines 85452 85447 -5
================================================
- Hits 66369 66356 -13
- Misses 14121 14127 +6
- Partials 4962 4964 +2 |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
@hicqu maybe we can add target addr in this log to help know fail target address
|
/run-all-tests |
What problem does this PR solve?
When TiDB trys to re-create the connection to one TiKV, it just checks itself is shutdown or not for the first time. After that TiDB will keep retry if the re-create always fail.
What is changed and how it works?
With this PR TiDB will check it's shutdown or not for every retry, so it can exit successfully.