Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect "Internal" display in admin show slow output #10338

Merged
merged 2 commits into from
May 5, 2019

Conversation

gunjanpatidar
Copy link
Contributor

What problem does this PR solve?

Fixes the incorrect output for "Internal" in admin show slow output

What is changed and how it works?

Just the output was inverted

Check List

Tests

  • None exist

Code changes

  • Has exported function/method change
    No
  • Has exported variable/fields change
    No
  • Has interface methods change
    No
  • Has persistent data change
    No

Side effects

  • Possible performance regression
    No
  • Increased code complexity
    No
  • Breaking backward compatibility
    Possibly for someone depending on incorrect output

Related changes

  • Need to cherry-pick to the release branch
    No
  • Need to update the documentation
    No
  • Need to update the tidb-ansible repository
    No
  • Need to be included in the release note
    No

@CLAassistant
Copy link

CLAassistant commented May 4, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@62d37a8). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #10338   +/-   ##
===========================================
  Coverage          ?   77.6767%           
===========================================
  Files             ?        411           
  Lines             ?      85431           
  Branches          ?          0           
===========================================
  Hits              ?      66360           
  Misses            ?      14108           
  Partials          ?       4963

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli shenli added the status/LGT2 Indicates that a PR has LGTM 2. label May 5, 2019
@shenli
Copy link
Member

shenli commented May 5, 2019

/run-all-tests

@shenli
Copy link
Member

shenli commented May 5, 2019

@gunjanpatidar Thanks for your contribution! Could you please sign the CLA?

@ngaut ngaut merged commit 0b037aa into pingcap:master May 5, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants