stats: incremental analyze for index with feedback updates #10355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10355 +/- ##
===============================================
- Coverage 77.3741% 77.374% -0.0002%
===============================================
Files 412 412
Lines 85588 85636 +48
===============================================
+ Hits 66223 66260 +37
- Misses 14339 14349 +10
- Partials 5026 5027 +1 |
|
/run-all-tests |
|
/run-all-tests |
|
/run-unit-test |
winoros
reviewed
May 6, 2019
eurekaka
reviewed
May 6, 2019
|
Can we remove the |
|
@eurekaka That means we need to analyze at least 1/256 rows, we can do it better when there are no feedbacks. |
How does this come from? |
eurekaka
reviewed
May 7, 2019
Since we have 256 buckets in a histogram and they are equal depth, so truncate one bucket would lead to analyze at least 1/256 rows. Also, the |
qw4990
reviewed
May 7, 2019
qw4990
reviewed
May 7, 2019
zz-jason
reviewed
May 7, 2019
|
/run-all-tests |
alivxxx
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support incremental analyze for the index with feedback updates.
What is changed and how it works?
For index with feedback updates, we will analyze from the last analyze position and merges it with the previous stats.
Check List
Tests
Code changes
Side effects
Related changes