Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: improve package unit test code coverage to 92% #10360

Merged
merged 2 commits into from
May 7, 2019

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Improve test code coverage

What is changed and how it works?

Add test code

Check List

Tests

  • Unit test

@tiancaiamao
Copy link
Contributor Author

PTAL @winkyao @jackysp

@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #10360 into master will increase coverage by 0.0047%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #10360        +/-   ##
================================================
+ Coverage   77.3142%   77.3189%   +0.0047%     
================================================
  Files           412        412                
  Lines         85547      85534        -13     
================================================
- Hits          66140      66134         -6     
+ Misses        14387      14379         -8     
- Partials       5020       5021         +1

@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #10360 into master will increase coverage by 0.0296%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #10360        +/-   ##
================================================
+ Coverage   77.6576%   77.6872%   +0.0296%     
================================================
  Files           411        411                
  Lines         85434      85449        +15     
================================================
+ Hits          66346      66383        +37     
+ Misses        14127      14107        -20     
+ Partials       4961       4959         -2

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat
Copy link

imtbkcat commented May 7, 2019

/run-all-tests

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao merged commit 17c3229 into pingcap:master May 7, 2019
@tiancaiamao tiancaiamao deleted the ut-cover-table branch May 7, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants