-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: generate IndexMergePath in physical optimization #10512
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10512 +/- ##
===========================================
Coverage 81.1334% 81.1334%
===========================================
Files 419 419
Lines 90801 90801
===========================================
Hits 73670 73670
Misses 11877 11877
Partials 5254 5254 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hailanwhu please resolve conflicts. |
/rebuild |
planner/core/stats.go
Outdated
path.index = ds.possibleAccessPaths[i].index | ||
noIntervalRanges, err := ds.deriveIndexPathStats(path, conditions) | ||
if err != nil { | ||
logutil.BgLogger().Info("can not derive statistics of a path") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the new variable in NewSessionVars
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/run-all-tests |
What problem does this PR solve?
Fix #10518
Part of implement for Proposal
Access a table using multiple indexes
. This pr implementsIndexMergeOrPath
generation.What is changed and how it works?
Add path generation and generate
IndexMergePath
Check List
Tests
Code changes
add
planner/core/indexmerge_test.go
add
generateIndexMergeOrPaths()
in planner/core/stats.gomodify
(ds *DataSource) deriveIndexPathStats()