store/tikv/gc_worker: Add config to specify gc concurrency manually #10561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
MyonKeminta
changed the title
MyonKeminta
changed the title
Codecov Report
@@ Coverage Diff @@
## master #10561 +/- ##
===============================================
- Coverage 78.3433% 78.3373% -0.006%
===============================================
Files 414 414
Lines 87668 87704 +36
===============================================
+ Hits 68682 68705 +23
- Misses 13853 13856 +3
- Partials 5133 5143 +10 |
disksing
approved these changes
Jun 3, 2019
MyonKeminta
added a commit
to MyonKeminta/tidb
that referenced
this pull request
Jun 12, 2019
jackysp
pushed a commit
that referenced
this pull request
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com
What problem does this PR solve?
Now in master branch TiDB always uses number of up stores as the gc concurrency (now gc concurrency is used for ResolveLocks and will be used for notifying delete range too). However it's useful to make it still configurable. This PR makes it possible to fallback to use configured concurrency, rather than use number of up stores directly.
What is changed and how it works?
This PR adds a new config
tikv_gc_auto_concurrencytomysql.tidb. It's defalt value istrue. When it'strue,tikv_gc_concurrencywill be ignored; and when it'sfalse,tikv_gc_concurrency's value will be used as the concurrency.Check List
Tests
Related changes