Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core,binloginfo: add a projection to fix 'delete from join' schema (#8805) #10595

Merged
merged 1 commit into from
May 26, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry pick from #8805

…chema (pingcap#8805)

'delete from t where a in (select ...) or b in (select ...)'
The correct schema should be the schema of t, rather than the schema of
the join. Add a projection in this case.
@tiancaiamao tiancaiamao requested a review from lysu May 25, 2019 14:28
@tiancaiamao
Copy link
Contributor Author

PTAL @jackysp @lysu

@zz-jason
Copy link
Member

LGTM

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor

lysu commented May 26, 2019

/run-all-test tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label May 26, 2019
@jackysp
Copy link
Member

jackysp commented May 26, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@ngaut ngaut merged commit b02831d into pingcap:release-2.1 May 26, 2019
@tiancaiamao tiancaiamao deleted the delete-schema branch May 26, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants