store/tikv: fix goroutine leak in gcworker #10622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @MyonKeminta @disksing |
Codecov Report
@@ Coverage Diff @@
## master #10622 +/- ##
===============================================
+ Coverage 77.6835% 77.693% +0.0094%
===============================================
Files 413 413
Lines 87505 87560 +55
===============================================
+ Hits 67977 68028 +51
- Misses 14376 14378 +2
- Partials 5152 5154 +2 |
|
/run-all-tests |
|
PTAL @MyonKeminta @disksing |
MyonKeminta
approved these changes
May 29, 2019
|
@disksing PTAL |
disksing
reviewed
May 29, 2019
| select { | ||
| case taskCh <- task: | ||
| case <-ctx.Done(): | ||
| break |
There was a problem hiding this comment.
I think need return err here.
There was a problem hiding this comment.
It should run to line https://github.com/pingcap/tidb/pull/10622/files#diff-8a388eccc19df74aa4991690c5f508a5L192 to return error!
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Jun 3, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix goroutine leak:
What is changed and how it works?
In range task runner's
RunOnRangefunction, it create many workers, and dispatch task to the workers through thetaskCh.When the worker meets the first error, it call
cancel, which makes all workers exit, but the dispatch loop is still writing to the channel... soRunOnRangeblocks on heretaskCh <- taskforever.In this commit I make the sender check
<-ctx.Done()to handle the error caseCheck List
Tests
Our schrodinger test platform find this leak and it's easy to reproduce there.
Related changes