planner: fix wrong selectivity for inner selection in index join #10633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/bugfix
|
/run-all-tests |
|
/run-integration-common-test |
alivxxx
reviewed
May 31, 2019
qw4990
reviewed
May 31, 2019
| logutil.Logger(context.Background()).Warn("calculate selectivity faild, use selection factor", zap.Error(err)) | ||
| selectivity = selectionFactor | ||
| } | ||
| path.countAfterIndex = rowCount * selectivity |
There was a problem hiding this comment.
How about make a new method on path for line 596~603 and exhaust_physical_plans.go:506~513.
There was a problem hiding this comment.
Hmm, these lines are simple enough and are unnecessary to be extracted?
Codecov Report
@@ Coverage Diff @@
## master #10633 +/- ##
================================================
- Coverage 80.1788% 80.1579% -0.0209%
================================================
Files 415 415
Lines 88350 88358 +8
================================================
- Hits 70838 70826 -12
- Misses 12273 12293 +20
Partials 5239 5239 |
eurekaka
commented
Jun 1, 2019
| ├─IndexScan_15 10.00 cop table:rr, index:aid, dic, range: decided by [eq(test.rr.aid, test.dt.aid) eq(test.rr.dic, test.dt.dic)], keep order:false, stats:pseudo | ||
| └─Selection_17 3.33 cop eq(test.rr.pt, "ios"), gt(test.rr.t, 1478185592) | ||
| └─Selection_17 0.00 cop eq(test.rr.pt, "ios"), gt(test.rr.t, 1478185592) |
There was a problem hiding this comment.
Note: the real row count here is 0.003333333333333334, which is reasonable; it is displayed as 0.00 because we are using count := string(strconv.AppendFloat([]byte{}, p.statsInfo().RowCount, 'f', 2, 64)) in prepareOperatorInfo.
|
/run-all-tests |
zz-jason
reviewed
Jun 4, 2019
eurekaka
force-pushed
the
selectivity_index_join_inner
branch
from
50fe0e5 to
eacdab0
Compare
eurekaka
force-pushed
the
selectivity_index_join_inner
branch
from
a920e5d to
3046a25
Compare
alivxxx
approved these changes
Jun 12, 2019
alivxxx
added
status/LGT2
eurekaka
added a commit
to eurekaka/tidb
that referenced
this pull request
Jun 19, 2019
eurekaka
added a commit
to eurekaka/tidb
that referenced
this pull request
Jun 19, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jun 20, 2019
winkyao
pushed a commit
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #10630
What is changed and how it works?
ds.statsas table plan's stats when it is double read in index join's inner side, because for inner child of index join, we are building new stats using average row count from scratch, so it is different from normalDataSource::DeriveStats;Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes