store/tikv: remove canceled requests before sending #10634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10634 +/- ##
==============================================
- Coverage 77.6801% 77.68% -0.0001%
==============================================
Files 413 413
Lines 87505 87563 +58
==============================================
+ Hits 67974 68019 +45
- Misses 14378 14387 +9
- Partials 5153 5157 +4 |
Codecov Report
@@ Coverage Diff @@
## master #10634 +/- ##
================================================
+ Coverage 78.1549% 78.1701% +0.0151%
================================================
Files 413 413
Lines 87498 87568 +70
================================================
+ Hits 68384 68452 +68
- Misses 13971 13972 +1
- Partials 5143 5144 +1 |
hicqu
reviewed
May 31, 2019
| @@ -506,6 +514,23 @@ func (a *connArray) batchSendLoop(cfg config.TiKVClient) { | |||
| } | |||
| } | |||
|
|
|||
| // removeCanceledRequests removes canceled requests before sending. | |||
| func removeCanceledRequests( | |||
There was a problem hiding this comment.
How about write the logic in fetchPendingRequest to reduce allocaction?
There was a problem hiding this comment.
It's possible that after wait for tikv overload, some of the requests canceled.
This way removes more canceled requests.
|
@lysu PTAL |
|
LGTM |
hicqu
previously approved these changes
May 31, 2019
|
/run-all-tests |
|
/run-integration-common-test |
|
/run-integration-common-test |
|
@tiancaiamao PTAL |
|
/run-all-tests |
|
LGTM |
tiancaiamao
approved these changes
May 31, 2019
coocood
added a commit
to coocood/tidb
that referenced
this pull request
May 31, 2019
coocood
added a commit
that referenced
this pull request
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When requests are canceled, we still send the requests to TiKV.
What is changed and how it works?
Remove the canceled requests before sending.
Check List
Tests