Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: reset groupChecker for StreamAggExec when Close (#10615) #10636

Merged
merged 2 commits into from
May 30, 2019
Merged

executor: reset groupChecker for StreamAggExec when Close (#10615) #10636

merged 2 commits into from
May 30, 2019

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #10615

@XuHuaiyu XuHuaiyu requested review from qw4990 and alivxxx May 29, 2019 06:47
alivxxx
alivxxx reviewed May 29, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label May 29, 2019
qw4990
qw4990 approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990
Copy link
Contributor

qw4990 commented May 29, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 29, 2019
@XuHuaiyu
Copy link
Contributor Author

/run-unit-test

@zz-jason zz-jason merged commit 52dde3b into pingcap:release-3.0 May 30, 2019
@XuHuaiyu XuHuaiyu deleted the release-3.0 branch May 30, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuHuaiyu @qw4990 @alivxxx @zz-jason