Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: refine HashAgg.Close when unparallelExec #10656

Merged
merged 2 commits into from
May 30, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry pick #8810

Only the bug fix, without the test code, because the file struct has changed dramaticly and there is no seqtest/seq_executor_test.go in release-2.1

@XuHuaiyu @zz-jason @eurekaka

@tiancaiamao tiancaiamao added type/2.1 cherry-pick type/bugfix This PR fixes a bug. sig/execution SIG execution priority/release-blocker This issue blocks a release. Please solve it ASAP. labels May 30, 2019
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
BTW, no need to cherry -pick the test?

@crazycs520
Copy link
Contributor

/run-all-tests

@crazycs520
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@winkyao winkyao merged commit 5ea2830 into pingcap:release-2.1 May 30, 2019
@tiancaiamao tiancaiamao deleted the hashagg-close branch June 4, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants