-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema/slow_query: add host column in slow_query table. #10693
Conversation
infoschema/slow_log.go
Outdated
@@ -162,6 +163,7 @@ type slowQueryTuple struct { | |||
time time.Time | |||
txnStartTs uint64 | |||
user string | |||
ip string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think host
is better
Codecov Report
@@ Coverage Diff @@
## master #10693 +/- ##
================================================
+ Coverage 78.3279% 78.3598% +0.0318%
================================================
Files 414 414
Lines 87666 87721 +55
================================================
+ Hits 68667 68738 +71
+ Misses 13854 13841 -13
+ Partials 5145 5142 -3 |
Codecov Report
@@ Coverage Diff @@
## master #10693 +/- ##
================================================
- Coverage 79.6423% 79.6412% -0.0012%
================================================
Files 414 414
Lines 87731 87736 +5
================================================
+ Hits 69871 69874 +3
- Misses 12688 12689 +1
- Partials 5172 5173 +1 |
Co-Authored-By: Zhang Jian <zjsariel@gmail.com>
Co-Authored-By: Zhang Jian <zjsariel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Add
host
field to classification byhost
.What is changed and how it works?
Add
host
field column to slow_query table. This is split value of "user".Check List
Tests
Code changes