Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, executor: return TableDual when tryFastPlan is promised to be false (#10676) #10699

Merged
merged 1 commit into from
Jun 4, 2019
Merged

planner, executor: return TableDual when tryFastPlan is promised to be false (#10676) #10699

merged 1 commit into from
Jun 4, 2019

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Jun 4, 2019 •
edited
Loading

cherry-pick #10676

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/3.0 cherry-pick labels Jun 4, 2019
@XuHuaiyu XuHuaiyu requested review from zz-jason and qw4990 June 4, 2019 06:48
zz-jason
zz-jason approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Jun 4, 2019

/run-all-tests

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2019
qw4990
qw4990 approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 477186c into pingcap:release-3.0 Jun 4, 2019
@zz-jason zz-jason added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. labels Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuHuaiyu @zz-jason @qw4990