-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: add MySQL extension assignment support for VariableAssignment #10700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangenta
force-pushed
the
mysql-ext-assignment
branch
from
June 4, 2019 07:33
0a97dd7
to
2cc9b58
Compare
Codecov Report
@@ Coverage Diff @@
## master #10700 +/- ##
==============================================
- Coverage 79.633% 79.6241% -0.009%
==============================================
Files 414 414
Lines 87696 87736 +40
==============================================
+ Hits 69835 69859 +24
- Misses 12687 12698 +11
- Partials 5174 5179 +5 |
winkyao
reviewed
Jun 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bb7133
approved these changes
Jun 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Jun 5, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Update parser for pingcap/parser#346.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes