Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add MySQL extension assignment support for VariableAssignment #10700

Merged
merged 4 commits into from
Jun 4, 2019

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jun 4, 2019

What problem does this PR solve?

Update parser for pingcap/parser#346.

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2019

CLA assistant check
All committers have signed the CLA.

@tangenta tangenta force-pushed the mysql-ext-assignment branch from 0a97dd7 to 2cc9b58 Compare June 4, 2019 07:33
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #10700 into master will decrease coverage by 0.0089%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##            master     #10700       +/-   ##
==============================================
- Coverage   79.633%   79.6241%   -0.009%     
==============================================
  Files          414        414               
  Lines        87696      87736       +40     
==============================================
+ Hits         69835      69859       +24     
- Misses       12687      12698       +11     
- Partials      5174       5179        +5

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants