planner, executor: return TableDual in tryFastPlan for predicate like handlePK=1.1 #10716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handlePK=non-int-const
|
/run-all-tests |
zz-jason
reviewed
Jun 5, 2019
executor/executor_test.go
Outdated
| @@ -3857,6 +3857,22 @@ func (s *testSuite) TestIssue10448(c *C) { | |||
| tk.MustQuery("desc select * from t where pk = 9223372036854775808").Check(testkit.Rows("Point_Get_1 1.00 root table:t, handle:9223372036854775808")) | |||
| } | |||
|
|
|||
| func (s *testSuite) TestIssue10677(c *C) { | |||
There was a problem hiding this comment.
maybe it's more proper to move this test to testPointGetSuite
Codecov Report
@@ Coverage Diff @@
## master #10716 +/- ##
================================================
+ Coverage 79.6677% 79.6816% +0.0139%
================================================
Files 414 414
Lines 87811 87827 +16
================================================
+ Hits 69957 69982 +25
+ Misses 12674 12667 -7
+ Partials 5180 5178 -2 |
|
/run-all-tests |
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Jun 6, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #10677
What is changed and how it works?
Return TableDual when the predicate is
PKIsHandle = 1.1.Check List
Tests
Code changes
Side effects
N/A
Related changes