Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: ByItem should filter NULL out (#10488) #10724

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Jun 5, 2019

What problem does this PR solve?

cherry-pick part of #10488

@winoros winoros added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Jun 5, 2019
@winoros winoros requested review from zz-jason, qw4990 and alivxxx June 5, 2019 07:49
@winoros winoros changed the title planner: ByItem should filter NULL out #10488 planner: ByItem should filter NULL out (#10488) Jun 5, 2019
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Jun 5, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 10f909d into pingcap:release-2.1 Jun 5, 2019
@winoros winoros deleted the pick3 branch June 26, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants