Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, expression: Disallow add stored generated columns through ALTER TABLE #10758

Merged
merged 3 commits into from
Jun 13, 2019
Merged

ddl, expression: Disallow add stored generated columns through ALTER TABLE #10758

merged 3 commits into from
Jun 13, 2019

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jun 11, 2019 •
edited
Loading

What problem does this PR solve?

A temporary solution for issue 9372.

According to current TiDB document, adding stored generated columns are not supported:

You cannot add the generated column in the storage type of STORED through ALTER TABLE.

So, an error should be returned for such statements.

What is changed and how it works?

  • A check in AddColumn()
  • Other redability improvements

Check the properties of the new column, if it is both Generated and Stored, return an errUnsupportedOnGeneratedColumn error.

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Jun 11, 2019 •
edited
Loading

Codecov Report

Merging #10758 into master will decrease coverage by 0.104%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10758        +/-   ##
================================================
- Coverage   80.3695%   80.2655%   -0.1041%     
================================================
  Files           416        416                
  Lines         88913      88419       -494     
================================================
- Hits          71459      70970       -489     
- Misses        12224      12241        +17     
+ Partials       5230       5208        -22

@tangenta tangenta requested a review from bb7133 June 11, 2019 03:47
crazycs520
crazycs520 reviewed Jun 12, 2019
View reviewed changes
ddl/generated_column.go Outdated Show resolved Hide resolved
crazycs520
crazycs520 reviewed Jun 12, 2019
View reviewed changes
ddl/generated_column.go Outdated Show resolved Hide resolved
@tangenta tangenta force-pushed the generated-col-limit branch 2 times, most recently from 8052216 to b612cc5 Compare June 12, 2019 15:37
bb7133
bb7133 reviewed Jun 12, 2019
View reviewed changes
ddl/db_test.go Outdated Show resolved Hide resolved
ddl/db_test.go Outdated Show resolved Hide resolved
ddl/db_test.go Outdated Show resolved Hide resolved
ddl/ddl.go Outdated Show resolved Hide resolved
ddl/generated_column.go Outdated Show resolved Hide resolved
ddl/generated_column.go Outdated Show resolved Hide resolved
@tangenta tangenta force-pushed the generated-col-limit branch 2 times, most recently from e332bf6 to c24bcb8 Compare June 13, 2019 02:13
crazycs520
crazycs520 reviewed Jun 13, 2019
View reviewed changes
ddl/generated_column.go Outdated Show resolved Hide resolved
crazycs520
crazycs520 reviewed Jun 13, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@tangenta tangenta force-pushed the generated-col-limit branch from 95b2025 to 92f0a5a Compare June 13, 2019 03:39
bb7133
bb7133 reviewed Jun 13, 2019
View reviewed changes
ddl/generated_column.go Outdated Show resolved Hide resolved
ddl/generated_column.go Outdated Show resolved Hide resolved
bb7133
bb7133 reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added component/DDL-need-LGT3 status/LGT2 Indicates that a PR has LGTM 2. labels Jun 13, 2019
zimulala
zimulala reviewed Jun 13, 2019
View reviewed changes
ddl/generated_column.go Outdated Show resolved Hide resolved
ddl/db_test.go Outdated Show resolved Hide resolved
@tangenta tangenta force-pushed the generated-col-limit branch from 92f0a5a to b469597 Compare June 13, 2019 12:04
winkyao
winkyao approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented Jun 13, 2019

/run-all-tests

@tangenta
Copy link
Contributor Author

/run-all-tests

@tangenta tangenta merged commit c59a108 into pingcap:master Jun 13, 2019
tangenta added a commit to tangenta/tidb that referenced this pull request Jun 14, 2019
@tangenta
ddl, expression: Disallow add stored generated columns through ALTER …
f956967 
…TABLE (pingcap#10758)
@tangenta tangenta mentioned this pull request Jun 14, 2019
Merged
@tangenta tangenta deleted the generated-col-limit branch June 14, 2019 02:34
@crazycs520 crazycs520 mentioned this pull request Jun 14, 2019
Closed
jackysp pushed a commit that referenced this pull request Jun 17, 2019
@tangenta @jackysp
ddl, expression: Disallow add stored generated columns through ALTER …
23d8d2b 
…TABLE (#10758) (#10808)
@Deardrops Deardrops mentioned this pull request Feb 20, 2020
Merged
12 tasks
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@zimulala zimulala zimulala left review comments

@bb7133 bb7133 bb7133 left review comments

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tangenta @winkyao @bb7133 @zimulala @crazycs520 @you06