update vendor to build on ARM64 #10805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seem the failed CI is not related to this change PTAL @zhouqiang-cl |
|
/run-all-tests |
|
go mod tidy failed |
|
Do you know how to fix it? |
|
@tiancaiamao PTAL |
Codecov Report
@@ Coverage Diff @@
## master #10805 +/- ##
================================================
+ Coverage 80.2873% 80.2878% +0.0004%
================================================
Files 417 417
Lines 88451 88453 +2
================================================
+ Hits 71015 71017 +2
+ Misses 12231 12225 -6
- Partials 5205 5211 +6 |
|
PTAL @shenli |
|
/run-all-tests |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jul 9, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jul 11, 2019
|
@winkyao I need some help of yours :). So i am building the image for arm64 to host it in my private artifactory.. i have tried with v5.0.2 and v4.0.0 . Images is getting build but while running the container getting this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Build TiDB on ARM64
What is changed and how it works?
Update vendor
Check List
Tests