Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix a corner case in column pruning rule (#10974) #11019

Merged
merged 1 commit into from
Jul 2, 2019
Merged

planner: fix a corner case in column pruning rule (#10974) #11019

merged 1 commit into from
Jul 2, 2019

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Jul 1, 2019

Cherry-pick #10974

zz-jason
zz-jason reviewed Jul 2, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor

eurekaka commented Jul 2, 2019

@bb7133 CI failed, PTAL

@bb7133
Copy link
Member Author

bb7133 commented Jul 2, 2019

hi @eurekaka @zz-jason , CI failed because in v2.1 PruneColumns() doesn't return anything, so I ignored the error returned from NewAggFuncDesc but CI complained.

Now I added a panic to handle the possible error. Not sure if this is a good idea:

https://github.com/pingcap/tidb/pull/11019/files#diff-e96c32593ee8e5ead5adbd45e60e61d9R106

@bb7133
Copy link
Member Author

bb7133 commented Jul 2, 2019

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@bb7133
Copy link
Member Author

bb7133 commented Jul 2, 2019

/run-integration-ddl-test tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@eurekaka
Copy link
Contributor

eurekaka commented Jul 2, 2019

Now I added a panic to handle the possible error. Not sure if this is a good idea

I think it's fine, because the panic should never be triggered for first_row(1)

eurekaka
eurekaka approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 2, 2019
@ngaut ngaut merged commit 2a0d4ce into pingcap:release-2.1 Jul 2, 2019
XuHuaiyu pushed a commit to XuHuaiyu/tidb that referenced this pull request Jul 4, 2019
@bb7133 @XuHuaiyu
planner: fix a corner case in column pruning rule (pingcap#10974) (pi…
6225390 
…ngcap#11019)
@bb7133 bb7133 deleted the bb7133/cherry-pick_10974 branch December 29, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@eurekaka eurekaka eurekaka approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bb7133 @eurekaka @zz-jason @ngaut