-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix the Host column of 'show processlist' #11069
Conversation
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11069 +/- ##
===========================================
Coverage 81.1622% 81.1622%
===========================================
Files 419 419
Lines 90053 90053
===========================================
Hits 73089 73089
Misses 11700 11700
Partials 5264 5264 |
/run-all-tests |
/run-integration-common-test |
@@ -990,6 +990,9 @@ func (s *session) SetProcessInfo(sql string, t time.Time, command byte, maxExecu | |||
if s.sessionVars.User != nil { | |||
pi.User = s.sessionVars.User.Username | |||
pi.Host = s.sessionVars.User.Hostname | |||
if s.sessionVars.ConnectionInfo != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put this check outside of if s.sessionVars.User != nil {
?
hi @wshwsh12 , how about add a new |
What problem does this PR solve?
#10903
The
Host
column should behost_name:client_port
format.What is changed and how it works?
open 2 mysql client and run
show processlist;
both.Before this pr:
This pr:
Check List
Tests
Code changes
Side effects
Related changes