Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: allow more charset/collation modifications for database/table (#10958) #11085

Merged
merged 4 commits into from
Jul 9, 2019

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Jul 4, 2019

Cherry-pick #10958

@bb7133 bb7133 changed the title ddl: allow more charset/collation modifications for database/table (#… ddl: allow more charset/collation modifications for database/table (#10958) Jul 4, 2019
@bb7133
Copy link
Member Author

bb7133 commented Jul 5, 2019

/rebuild

@bb7133 bb7133 force-pushed the bb7133/cherry-pick_10958_2.1 branch from 2638d8a to 4a8d083 Compare July 5, 2019 01:26
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

zimulala commented Jul 5, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@zz-jason
Copy link
Member

zz-jason commented Jul 6, 2019

/run-integration-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1
/run-integration-ddl-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. labels Jul 6, 2019
@zz-jason
Copy link
Member

zz-jason commented Jul 9, 2019

/run-integration-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1
/run-integration-ddl-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zimulala
Copy link
Contributor

zimulala commented Jul 9, 2019

/run-integration-ddl-test

@zimulala
Copy link
Contributor

zimulala commented Jul 9, 2019

/run-all-tests

@bb7133
Copy link
Member Author

bb7133 commented Jul 9, 2019

/run-all-tests

@zz-jason zz-jason merged commit e3914bf into pingcap:release-2.1 Jul 9, 2019
@bb7133 bb7133 deleted the bb7133/cherry-pick_10958_2.1 branch December 29, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants