Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix privilege check for 'show create user current_user()' #11142

Merged
merged 2 commits into from
Jul 9, 2019
Merged

executor: fix privilege check for 'show create user current_user()' #11142

merged 2 commits into from
Jul 9, 2019

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Fix issue #10445

What is changed and how it works?

  1. "show create user" for somebody other than current user should check privilege
  2. fix the username and host for "show create user current_user()"

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@codecov
Copy link

codecov bot commented Jul 9, 2019 •
edited
Loading

Codecov Report

Merging #11142 into master will increase coverage by 0.0469%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             master     #11142       +/-   ##
===============================================
+ Coverage   81.0753%   81.1223%   +0.047%     
===============================================
  Files           421        420        -1     
  Lines         89735      89630      -105     
===============================================
- Hits          72753      72710       -43     
+ Misses        11722      11664       -58     
+ Partials       5260       5256        -4

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

PTAL @imtbkcat @jackysp

imtbkcat
imtbkcat reviewed Jul 9, 2019
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 9, 2019
jackysp
jackysp approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit bd4130d into pingcap:master Jul 9, 2019
@imtbkcat
Copy link

@tiancaiamao please cherry-pick this pr to release-3.0 and release-2.1

tiancaiamao added a commit to tiancaiamao/tidb that referenced this pull request Jul 12, 2019
@tiancaiamao
executor: fix privilege check for 'show create user current_user()' (p…
b34a8fd 
…ingcap#11142)
@tiancaiamao tiancaiamao mentioned this pull request Jul 12, 2019
Merged
@tiancaiamao tiancaiamao deleted the show-create-user branch July 12, 2019 06:34
tiancaiamao added a commit to tiancaiamao/tidb that referenced this pull request Oct 30, 2019
@tiancaiamao
executor: fix privilege check for 'show create user current_user()' p…
686a3b8 
…ingcap#11142
@tiancaiamao tiancaiamao mentioned this pull request Oct 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imtbkcat imtbkcat imtbkcat left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
component/privilege status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiancaiamao @imtbkcat @jackysp