Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix data race of rand function (#11168) #11170

Merged
merged 2 commits into from
Jul 11, 2019
Merged

expression: fix data race of rand function (#11168) #11170

merged 2 commits into from
Jul 11, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jul 10, 2019

Cherry pick #11168
No conflicts.

@alivxxx alivxxx requested review from winkyao and winoros July 10, 2019 09:53
eurekaka
eurekaka reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 11, 2019
@alivxxx
Copy link
Contributor Author

alivxxx commented Jul 11, 2019

/run-all-tests

zz-jason
zz-jason approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 7cdce5b into pingcap:release-2.1 Jul 11, 2019
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 11, 2019
@alivxxx alivxxx deleted the race branch July 12, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@zz-jason zz-jason zz-jason approved these changes

@winkyao winkyao Awaiting requested review from winkyao

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alivxxx @zz-jason @eurekaka