Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: function INSERT should return NULL if any argument is NULL #11249

Merged
merged 3 commits into from
Jul 15, 2019
Merged

expression: function INSERT should return NULL if any argument is NULL #11249

merged 3 commits into from
Jul 15, 2019

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Jul 15, 2019 •
edited
Loading

Automated cherry pick of #11237 on release-2.1.
#11237: Function INSERT should be NULL if any argument is NULL.

@SunRunAway SunRunAway changed the title expression: function INSERT should return NULL if any argument is NULL Automated cherry pick of #11237 on release-2.1. #11237: Function INSERT should be NULL if any argument is NULL. expression: function INSERT should return NULL if any argument is NULL Jul 15, 2019
@XuHuaiyu XuHuaiyu requested a review from wshwsh12 July 15, 2019 03:59
@SunRunAway SunRunAway requested a review from eurekaka July 15, 2019 08:42
@wshwsh12
Copy link
Contributor

/run-all-tests

@wshwsh12
Copy link
Contributor

/run-all-tests

wshwsh12
wshwsh12 reviewed Jul 15, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2019
zz-jason
zz-jason approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason removed the request for review from eurekaka July 15, 2019 16:18
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2019
@zz-jason zz-jason merged commit 420c42f into pingcap:release-2.1 Jul 15, 2019
@zz-jason zz-jason mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunRunAway @wshwsh12 @zz-jason