Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: disable projection elimination for select plan of update (#10962) #11254

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Jul 15, 2019

cherry-pick #10962

Conflicts:
planner/core/cbo_test.go
planner/core/logical_plan_builder.go

…ngcap#10962)

Conflicts:
	planner/core/cbo_test.go
	planner/core/logical_plan_builder.go
@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Jul 15, 2019
@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2019
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eurekaka eurekaka merged commit 958257b into pingcap:release-2.1 Jul 15, 2019
@eurekaka eurekaka deleted the pick_2.1_proj_elim branch July 15, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants