Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix NAME_CONST function compatibility (#11241) #11268

Merged
merged 2 commits into from
Jul 18, 2019
Merged

planner: fix NAME_CONST function compatibility (#11241) #11268

merged 2 commits into from
Jul 18, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 16, 2019

cherry-pick #11241 to release-3.0

zz-jason
zz-jason reviewed Jul 16, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/3.0 cherry-pick type/bugfix This PR fixes a bug. labels Jul 16, 2019
@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason requested a review from SunRunAway July 18, 2019 11:41
@SunRunAway
Copy link
Contributor

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

SunRunAway
SunRunAway approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 18, 2019
@SunRunAway
Copy link
Contributor

/run-all-tests tikv=release-3.0 pd=release-3.0

@SunRunAway SunRunAway requested a review from zz-jason July 18, 2019 12:57
@zz-jason zz-jason merged commit 7ef017f into pingcap:release-3.0 Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @zz-jason @SunRunAway @b41sh