Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, types: fix Mod(%), Multiple(*), Minus(-) operators meets inconsistent 0 results. (#11251) #11353

Conversation

SunRunAway
Copy link
Contributor

Automated cherry pick of #11251 on release-2.1.
#11251: Fix #11211
Fix mul and minus
add unit test
add test for add and div

@SunRunAway
Copy link
Contributor Author

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway changed the title expression, types: fix Mod(%), Multiple(*), Minus(-) operators meets inconsistent 0 results. expression, types: fix Mod(%), Multiple(*), Minus(-) operators meets inconsistent 0 results. (#11251) Jul 22, 2019
@zz-jason zz-jason merged commit 03fccbe into pingcap:release-2.1 Jul 22, 2019
@SunRunAway SunRunAway deleted the automated-cherry-pick-of-#11251-upstream-release-2.1 branch August 15, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants