Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix autoid doesn't handle float, double type and tiny cleanup (#11110) #11389

Merged
merged 3 commits into from
Jul 23, 2019
Merged

executor: fix autoid doesn't handle float, double type and tiny cleanup (#11110) #11389

merged 3 commits into from
Jul 23, 2019

Conversation

lzmhhh123
Copy link
Contributor

cherry-pick #11110.
#11110: executor: fix autoid doesn't handle float, double type and tiny cleanup

zz-jason
zz-jason reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from eurekaka July 23, 2019 09:26
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2019
@zz-jason
Copy link
Member

/run-all-tests

imtbkcat
imtbkcat approved these changes Jul 23, 2019
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2019
@zz-jason zz-jason merged commit 81891c5 into pingcap:release-2.1 Jul 23, 2019
@lzmhhh123 lzmhhh123 deleted the release-2.1-cherry-pick-11110 branch July 24, 2019 05:51
bb7133 added a commit to bb7133/tidb that referenced this pull request Jun 11, 2021
@bb7133
cherry pick pingcap#11389
bd86369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@imtbkcat imtbkcat imtbkcat approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzmhhh123 @zz-jason @imtbkcat @nange