tikv: forbid to try to get a connection forever #11391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysu
reviewed
Jul 23, 2019
store/tikv/client_test.go
Outdated
| @@ -22,6 +22,9 @@ import ( | |||
| "github.com/pingcap/errors" | |||
| "github.com/pingcap/kvproto/pkg/tikvpb" | |||
| "github.com/pingcap/tidb/config" | |||
| "github.com/pingcap/tidb/store/tikv/tikvrpc" | |||
|
|
|||
| "fmt" | |||
There was a problem hiding this comment.
need move import to first group
|
@hicqu maybe better edit the description to follow TIDB PR template, our QA's tools will rely on PR template |
Codecov Report
@@ Coverage Diff @@
## master #11391 +/- ##
================================================
- Coverage 81.3685% 81.3024% -0.0662%
================================================
Files 423 423
Lines 90648 90616 -32
================================================
- Hits 73759 73673 -86
- Misses 11577 11619 +42
- Partials 5312 5324 +12 |
lysu
added
component/tikv
type/enhancement
lysu
changed the title
|
/run-all-tests |
|
LGTM |
|
Please fix CI. |
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #11404 |
hicqu
added a commit
to hicqu/tidb
that referenced
this pull request
Jul 30, 2019
jackysp
pushed a commit
that referenced
this pull request
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
SendRequestcould be block forever if all connectons are broken.What is changed and how it works?
Forbid to try to get a connection forever so that
SendRequestcan return immediately and try an another target peer.Check List
Tests
Related changes