Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDL: fix a bug in column charset and collate when create table and modify column(#11300) #11423

Merged
merged 4 commits into from
Jul 26, 2019

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

cherry-pick to release 2.1 #11300

Check List

Tests

  • Unit test
  • Integration test

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 26, 2019
@zimulala
Copy link
Contributor

/run-all-tests

@zz-jason zz-jason added component/DDL-need-LGT3 status/can-merge Indicates a PR has been approved by a committer. labels Jul 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit 13ba8b2 into pingcap:release-2.1 Jul 26, 2019
@AilinKid AilinKid changed the title DDL: fix a bug in column charset and collate when create table and modify column DDL: fix a bug in column charset and collate when create table and modify column(#11300) Jul 27, 2019
AilinKid added a commit to AilinKid/tidb that referenced this pull request Jul 29, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants