-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats: fix panic when dump pseudo columns #11430
Conversation
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #11430 +/- ##
===========================================
Coverage 81.4025% 81.4025%
===========================================
Files 424 424
Lines 90846 90846
===========================================
Hits 73951 73951
Misses 11595 11595
Partials 5300 5300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pseudo estimation with pseudo histograms is different with that without histograms?
I think no, this PR only initialize the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests |
@lamxTyler merge failed. |
/run-unit-test |
cherry pick to release-3.0 in PR #11460 |
cherry pick to release-2.1 failed |
What problem does this PR solve?
What is changed and how it works?
The histograms of the pseudo table are not initialized properly, the
bounds
of them may be nil, so it will panic when we try to dump the stats.Check List
Tests
Code changes
Side effects
Related changes