Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression, session: handle CASE WHEN specially when folding constant during outerJoin Simplification(#11105) #11441

Merged
merged 3 commits into from
Jul 26, 2019
Merged

expression, session: handle CASE WHEN specially when folding constant during outerJoin Simplification(#11105) #11441

merged 3 commits into from
Jul 26, 2019

Conversation

lovewin99
Copy link
Contributor

cherry-pick ##11105 to release-3.0

@lovewin99
expression, session: handle CASE WHEN specially when folding consta…
37ef7f9 
…nt during outerJoin Simplification (pingcap#11105)

Test pass, auto merge by Bot
@zz-jason zz-jason added component/expression contribution This PR is from a community contributor. type/3.0 cherry-pick labels Jul 25, 2019
@eurekaka
Copy link
Contributor

@lovewin99 CI failed, PTAL

@lovewin99
Copy link
Contributor Author

lovewin99 commented Jul 26, 2019 •
edited
Loading

@lovewin99 CI failed, PTAL

This problem is not caused by this commit. The latest code is merged and passed. @eurekaka

eurekaka
eurekaka reviewed Jul 26, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2019
@XuHuaiyu
Copy link
Contributor

/run-all-tests

XuHuaiyu
XuHuaiyu approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2019

@lovewin99 merge failed.

@lovewin99
Copy link
Contributor Author

lovewin99 commented Jul 26, 2019 •
edited
Loading

/run-all-tests

1 similar comment
@lovewin99
Copy link
Contributor Author

/run-all-tests

@zz-jason zz-jason merged commit ece299d into pingcap:release-3.0 Jul 26, 2019
@lovewin99 lovewin99 deleted the cherry-pick-3.0 branch July 30, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lovewin99 @eurekaka @XuHuaiyu @sre-bot @zz-jason