Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: support subquery in SHOW statement (#10942) #11461

Merged
merged 3 commits into from
Jul 26, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #10942

Conflicts:
planner/core/common_plans.go
planner/core/find_best_task.go
planner/core/initialize.go
planner/core/planbuilder.go
planner/core/resolve_indices.go

Conflicts:
	planner/core/common_plans.go
	planner/core/find_best_task.go
	planner/core/initialize.go
	planner/core/planbuilder.go
	planner/core/resolve_indices.go
@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Jul 26, 2019
@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@eurekaka
Copy link
Contributor Author

/run-unit-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit f299fb2 into pingcap:release-2.1 Jul 26, 2019
@eurekaka eurekaka deleted the pick_show_subq_21 branch July 29, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants