-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix invalid index on multi-layer virtual columns (#11260) #11475
ddl: fix invalid index on multi-layer virtual columns (#11260) #11475
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-common-test |
/run-all-tests |
randgen test keeps failing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@tangenta merge failed. |
/run-unit-test |
/run-unit-test |
/run-all-tests |
[2019-08-04T14:44:52.655Z] 2019/08/04 22:44:52.542 main.go:821: [fatal] run test [window_functions] err: sql:SELECT SUM(DISTINCT b) OVER () FROM t;: failed to run query
[2019-08-04T14:44:52.655Z] "SELECT SUM(DISTINCT b) OVER () FROM t;"
[2019-08-04T14:44:52.655Z] around line 1004,
[2019-08-04T14:44:52.655Z] we need(117):
[2019-08-04T14:44:52.655Z] SELECT SUM(DISTINCT b) OVER () FROM t;
[2019-08-04T14:44:52.655Z] Error 1235: This version of TiDB doesn't yet support '<window function>(DISTIN
[2019-08-04T14:44:52.655Z] but got(117):
[2019-08-04T14:44:52.655Z] SELECT SUM(DISTINCT b) OVER () FROM t;
[2019-08-04T14:44:52.655Z] SUM(DISTINCT b) OVER ()
[2019-08-04T14:44:52.655Z] 36
[2019-08-04T14:44:52.655Z] 36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Cherry-pick #11260.