Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: make region_request_test stable (#11541) #11558

Merged
merged 1 commit into from
Aug 1, 2019
Merged

tikv: make region_request_test stable (#11541) #11558

merged 1 commit into from
Aug 1, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Aug 1, 2019 •
edited
Loading

cherry-pick #11541 to 3.1

# Conflicts:
#	store/tikv/region_request_test.go

This change is Reviewable

@lysu
tikv: make region_request_test stable (#11541)
bf51b33 
# Conflicts:
#	store/tikv/region_request_test.go
@lysu lysu requested review from jackysp and imtbkcat August 1, 2019 05:20
@lysu
Copy link
Contributor Author

lysu commented Aug 1, 2019

/run-all-tests

jackysp
jackysp reviewed Aug 1, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 1, 2019
@jackysp jackysp mentioned this pull request Aug 1, 2019
Merged
imtbkcat
imtbkcat approved these changes Aug 1, 2019
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2019

/run-all-tests

@sre-bot sre-bot merged commit 5e27d4f into pingcap:release-3.0 Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@imtbkcat imtbkcat imtbkcat approved these changes

Assignees
No one assigned
Labels
component/test component/tikv status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysu @sre-bot @jackysp @imtbkcat