Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix bug that window function do not check ignore nulls. (#11554) #11593

Merged
merged 3 commits into from
Aug 5, 2019
Merged

planner: fix bug that window function do not check ignore nulls. (#11554) #11593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ced79bd
fix window function ignore nulls bug
lzmhhh123 Aug 1, 2019
a8c0570
add distinct and from_last check
lzmhhh123 Aug 1, 2019
2307aa7
fix ci
lzmhhh123 Aug 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions planner/core/logical_plan_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3218,6 +3218,15 @@ func (b *PlanBuilder) buildWindowFunctions(ctx context.Context, p LogicalPlan, g
// Because of the grouped specification is different from it, we should especially check them before build window frame.
func (b *PlanBuilder) checkOriginWindowSpecs(funcs []*ast.WindowFuncExpr, orderByItems []property.Item) error {
for _, f := range funcs {
if f.IgnoreNull {
return ErrNotSupportedYet.GenWithStackByArgs("IGNORE NULLS")
}
if f.Distinct {
return ErrNotSupportedYet.GenWithStackByArgs("<window function>(DISTINCT ..)")
}
if f.FromLast {
return ErrNotSupportedYet.GenWithStackByArgs("FROM LAST")
}
spec := f.Spec
if spec.Frame == nil {
continue
Expand Down
17 changes: 17 additions & 0 deletions planner/core/logical_plan_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2403,6 +2403,23 @@ func (s *testPlanSuite) TestWindowFunction(c *C) {
sql: "select dense_rank() over w1, a, b from t window w1 as (partition by t.b order by t.a asc range between 1250951168 following AND 1250951168 preceding)",
result: "[planner:3586]Window 'w1': frame start or end is negative, NULL or of non-integral type",
},
// Test issue 10556.
{
sql: "SELECT FIRST_VALUE(a) IGNORE NULLS OVER () FROM t",
result: "[planner:1235]This version of TiDB doesn't yet support 'IGNORE NULLS'",
},
{
sql: "SELECT SUM(DISTINCT a) OVER () FROM t",
result: "[planner:1235]This version of TiDB doesn't yet support '<window function>(DISTINCT ..)'",
},
{
sql: "SELECT NTH_VALUE(a, 1) FROM LAST over (partition by b order by b), a FROM t",
result: "[planner:1235]This version of TiDB doesn't yet support 'FROM LAST'",
},
{
sql: "SELECT NTH_VALUE(a, 1) FROM LAST IGNORE NULLS over (partition by b order by b), a FROM t",
result: "[planner:1235]This version of TiDB doesn't yet support 'IGNORE NULLS'",
},
}

s.Parser.EnableWindowFunc(true)
Expand Down