Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle builtin time getInterval from Decimal\Real (#11479) #11628

Merged
merged 1 commit into from
Aug 6, 2019
Merged

expression: handle builtin time getInterval from Decimal\Real (#11479) #11628

merged 1 commit into from
Aug 6, 2019

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Aug 5, 2019 •
edited
Loading

What problem does this PR solve?

cherry-pick: #11479 to release-2.1
conflict: expression/builtin_time_test.go

@wshwsh12 wshwsh12 added contribution This PR is from a community contributor. type/bugfix This PR fixes a bug. component/expression type/2.1 cherry-pick labels Aug 5, 2019
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Aug 5, 2019

/run-all-tests

XuHuaiyu
XuHuaiyu reviewed Aug 6, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2019
qw4990
qw4990 approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 6, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit 97ef360 into pingcap:release-2.1 Aug 6, 2019
@wshwsh12 wshwsh12 deleted the release-2.1 branch August 6, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wshwsh12 @sre-bot @qw4990 @XuHuaiyu @AndrewDi