Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindinfo: fix the bind fields with quotes or slashes #11671

Merged
merged 5 commits into from
Aug 13, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Aug 8, 2019

What problem does this PR solve?

Fix #11708

tidb>  CREATE TABLE t (a varchar(512) DEFAULT NULL, KEY idx (a));
Query OK, 0 rows affected (0.01 sec)

tidb> CREATE GLOBAL BINDING FOR  select * from t where a BETWEEN "a" and "b" USING select * from t use index(idx) where a BETWEEN "a" and "c";
ERROR 1105 (HY000): line 1 column 48 near "\"a\" and \"c\""

What is changed and how it works?

Remove the function of getEscapeCharacter .

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@alivxxx alivxxx added the type/bugfix This PR fixes a bug. label Aug 8, 2019
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #11671 into master will increase coverage by 0.9161%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #11671        +/-   ##
================================================
+ Coverage   81.4085%   82.3246%   +0.9161%     
================================================
  Files           429        428         -1     
  Lines         92650      96779      +4129     
================================================
+ Hits          75425      79673      +4248     
+ Misses        11827      11648       -179     
- Partials       5398       5458        +60

@qw4990 qw4990 requested review from qw4990 and alivxxx August 8, 2019 12:00
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 8, 2019
@qw4990
Copy link
Contributor

qw4990 commented Aug 8, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Aug 8, 2019

@zimulala Please fix the CI problem~

@zimulala
Copy link
Contributor Author

/run-integration-common-test
/run-unit-test

@zimulala
Copy link
Contributor Author

PTAL @qw4990

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2019

@zimulala merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Aug 12, 2019

/run-unit-test

@zz-jason
Copy link
Member

/run-unit-test

@zz-jason
Copy link
Member

Data race in the test is a known issue, will be fixed by #11639.

@zz-jason zz-jason merged commit 2cfdd9e into pingcap:master Aug 13, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 13, 2019

cherry pick to release-3.0 in PR #11726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields parsing with quotes or slash failed in create global binding
5 participants