fix some bugs in builtinCastIntAsRealSig and builtinCastIntAsDecimalSig that treat unsigned val as signed val
#11745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-ZeX
added
component/expression
needs-cherry-pick-2.1
type/bugfix
H-ZeX
force-pushed
the
fix-unsigned-bug
branch
from
dbda87d to
bdc8fd9
Compare
H-ZeX
changed the title
builtinCastIntAsRealSig and builtinCastIntAsDecimalSig that treat unsigned val as signed valbuiltinCastIntAsRealSig and builtinCastIntAsDecimalSig that treat unsigned val as signed val
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
H-ZeX
force-pushed
the
fix-unsigned-bug
branch
from
bdc8fd9 to
93d0bae
Compare
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #11745 +/- ##
===============================================
- Coverage 81.4489% 81.442% -0.0069%
===============================================
Files 433 433
Lines 93240 93184 -56
===============================================
- Hits 75943 75891 -52
+ Misses 11867 11865 -2
+ Partials 5430 5428 -2 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #11745 +/- ##
===============================================
- Coverage 81.4489% 81.442% -0.0069%
===============================================
Files 433 433
Lines 93240 93184 -56
===============================================
- Hits 75943 75891 -52
+ Misses 11867 11865 -2
+ Partials 5430 5428 -2 |
lonng
reviewed
Aug 21, 2019
| @@ -463,7 +463,7 @@ func (b *builtinCastIntAsRealSig) evalReal(row chunk.Row) (res float64, isNull b | |||
| } | |||
| if !mysql.HasUnsignedFlag(b.tp.Flag) && !mysql.HasUnsignedFlag(b.args[0].GetType().Flag) { | |||
There was a problem hiding this comment.
Prefer to:
if unsigned := mysql.HasUnsignedFlag(b.args[0].GetType().Flag); !mysql.HasUnsignedFlag(b.tp.Flag) && !unsigned {
} else if b.inUnion && !unsigned {
} else {
}
lonng
reviewed
Aug 21, 2019
| @@ -489,7 +489,7 @@ func (b *builtinCastIntAsDecimalSig) evalDecimal(row chunk.Row) (res *types.MyDe | |||
| } | |||
| if !mysql.HasUnsignedFlag(b.tp.Flag) && !mysql.HasUnsignedFlag(b.args[0].GetType().Flag) { | |||
| res = types.NewDecFromInt(val) | |||
| } else if b.inUnion && val < 0 { | |||
| } else if b.inUnion && !mysql.HasUnsignedFlag(b.args[0].GetType().Flag) && val < 0 { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: H-ZeX hzx20112012@gmail.com
What problem does this PR solve?
in the original version, it will check
inUnion && val<0no matter whether the val is unsigned(the val is always int64, but in sql, it may be unsigned), so in some case, it will dirrerent from mysql5.7What is changed and how it works?
add check of whether unsigned
Check List
Code changes
no.
Side effects
no.
Related changes