-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: refine pre-split region logic #11794
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11794 +/- ##
===========================================
Coverage 81.4701% 81.4701%
===========================================
Files 435 435
Lines 93719 93719
===========================================
Hits 76353 76353
Misses 11891 11891
Partials 5475 5475 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Related docs PR: pingcap/docs-cn#1780 |
@crazycs520 merge failed. |
/rebuild |
cherry pick to release-3.0 in PR #11796 |
cherry pick to release-2.1 in PR #11797 |
@crazycs520 Can we make |
@zz-jason For the compatibility, not suggest making |
What problem does this PR solve?
The original logic of
pre_split_region
will split 2^(pre_split_region -1
) regions. It was strange for the user to understand and remember it.This PR will simply split 2^(
pre_split_region
) regions whencreate table
withpre_split_region
.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release Note
pre_split_regions
logic for easy to understand and remember.