-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: give the full error message when the result of calling the exp function is out of range #11862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e exp function is out of range
Reminiscent
changed the title
expression: give the full error message when the result of calling th…
expression: give the full error message when the result of calling the exp function is out of range
Aug 26, 2019
zz-jason
reviewed
Aug 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #11862 +/- ##
===========================================
Coverage 81.4084% 81.4084%
===========================================
Files 439 439
Lines 95097 95097
===========================================
Hits 77417 77417
Misses 12198 12198
Partials 5482 5482 |
Reminiscent
requested review from
wshwsh12,
XuHuaiyu and
qw4990
and removed request for
qw4990
August 26, 2019 06:33
alivxxx
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alivxxx
added
status/LGT2
Indicates that a PR has LGTM 2.
status/can-merge
Indicates a PR has been approved by a committer.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Aug 27, 2019
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/compatibility
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix:#11197
the error message didn't contain a piece of complete information when the result of calling the exp function is out of range
What is changed and how it works?
when generating the error message compose it to databaseName.tableName.columnName format
Check List
Tests