Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: give the full error message when the result of calling the exp function is out of range #11862

Merged
merged 3 commits into from
Aug 27, 2019

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Aug 26, 2019

What problem does this PR solve?

fix:#11197
the error message didn't contain a piece of complete information when the result of calling the exp function is out of range

What is changed and how it works?

when generating the error message compose it to databaseName.tableName.columnName format

Check List

Tests

  • Unit test

@Reminiscent Reminiscent requested review from qw4990 and zz-jason August 26, 2019 03:28
@Reminiscent Reminiscent changed the title expression: give the full error message when the result of calling th… expression: give the full error message when the result of calling the exp function is out of range Aug 26, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2019
@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #11862 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11862   +/-   ##
===========================================
  Coverage   81.4084%   81.4084%           
===========================================
  Files           439        439           
  Lines         95097      95097           
===========================================
  Hits          77417      77417           
  Misses        12198      12198           
  Partials       5482       5482

@Reminiscent Reminiscent requested review from wshwsh12, XuHuaiyu and qw4990 and removed request for qw4990 August 26, 2019 06:33
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit b438bf2 into pingcap:master Aug 27, 2019
@Reminiscent Reminiscent deleted the fix#11197 branch August 31, 2019 00:51
@Reminiscent Reminiscent restored the fix#11197 branch August 31, 2019 00:51
@Reminiscent Reminiscent deleted the fix#11197 branch December 24, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function arguments in error message should represent as a column name if possible.
4 participants