Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: fix log slow log succ field (#11867) #11886

Merged
merged 3 commits into from
Aug 28, 2019
Merged

session: fix log slow log succ field (#11867) #11886

merged 3 commits into from
Aug 28, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 27, 2019

cherry-pick #11867 to release-2.1

What problem does this PR solve?

The succ field in the slow log was wrong when logging slow log for DDL/DML and admin show slow.

What is changed and how it works?

Check List

Tests

  • manual test.

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch(affect version: v2.1.16, v3.0.2)

Release note

  • Fix the issue that succ field in slow log and admin show low was wrong.

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 27, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Aug 27, 2019
Merged
jackysp
jackysp reviewed Aug 27, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason previously approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 27, 2019
@ngaut ngaut added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Aug 27, 2019
jackysp
jackysp approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Aug 28, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 28, 2019

Your auto merge job has been accepted, waiting for #11887

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 28, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Aug 28, 2019
Merged
@sre-bot sre-bot merged commit e33f2a5 into pingcap:release-2.1 Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@zz-jason zz-jason zz-jason left review comments

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @jackysp @zz-jason @ngaut @crazycs520